Re: [BUG/PATCH] x86 mmiotrace: dynamically disable non-boot CPUs

From: Steven Rostedt
Date: Wed Apr 16 2008 - 15:07:36 EST




On Wed, 16 Apr 2008, Ingo Molnar wrote:
>
> so lets fix those preemptability bugs. They show that the
> cpu-up/cpu-down ops are called from atomic context - it should normally
> be straightforward to sort out - there's no particular reason why the
> ->open()/->close() methods of an ftrace plugin should run in atomic
> context. Steve, any ideas where the atomicity might come from?
>

They shouldn't be called in an atomic section. The only thing I do to
protect them is call mutex_lock/unlock. Those should allow preemption to
take place.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/