Re: [PATCH 1/4] Add a basic debugging framework for memory initialisation

From: Mel Gorman
Date: Wed Apr 16 2008 - 15:30:29 EST


On (16/04/08 16:04), Ingo Molnar didst pronounce:
>
> * Mel Gorman <mel@xxxxxxxxx> wrote:
>
> > +static __init int set_mminit_debug_level(char *str)
> > +{
> > + get_option(&str, &mminit_debug_level);
> > + return 0;
> > +}
> > +early_param("mminit_debug_level", set_mminit_debug_level);
>
> another small suggestion: could you please also add a Kconfig method of
> enabling it, dependent on KERNEL_DEBUG, default-off (for now). The best
> would be not a numeric switch but something that gets randomized by
> "make randconfig". I.e. an on/off switch kind of things.
>

Makes sense. I've this and your other suggestions incorporated. It'll be
part of V2.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/