Re: [bug] build failure in net/netfilter/nf_conntrack_sip.c, onlatest -git

From: David Miller
Date: Sat Apr 19 2008 - 20:54:20 EST


From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Sat, 19 Apr 2008 18:38:41 +0200

> David Miller wrote:
> > From: Ingo Molnar <mingo@xxxxxxx>
> > Date: Sat, 19 Apr 2008 12:00:35 +0200
> >
> > [ netfilter-devel and netdev added to CC: ]
> >
> >
> >> randconfig testing found a netfilter build failure in latest -git:
> >>
> >> net/netfilter/nf_conntrack_sip.c: In function 'set_expected_rtp_rtcp':
> >> net/netfilter/nf_conntrack_sip.c:786: error: 'struct nf_conntrack_expect' has no member named 'saved_ip'
> >>
> >> http://redhat.com/~mingo/misc/config-Sat_Apr_19_11_37_02_CEST_2008.bad
> >>
> >> disabling CONFIG_NF_CONNTRACK_SIP works it around.
> >>
> >
> > I think this will fix it.
> >
> > Patrick, is this how we should do it?
>
> No, the SIP helper is also useful without NAT. This patch adds
> an ifdef around the RTP call optimization for NATed clients.
>
> Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

Fair enough, applied, thanks Patrick.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/