Re: [2.6 patch] make struct ocfs2_control_device static

From: Joel Becker
Date: Mon Apr 21 2008 - 06:02:37 EST


On Mon, Apr 21, 2008 at 11:49:26AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global struct ocfs2_control_device
> static.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
Acked-by: Joel Becker <joel.becker@xxxxxxxxxx>

>
> ---
> d8837f8ed79bc615105e5ca2724c3d22c9f26089 diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
> index 7428663..b503772 100644
> --- a/fs/ocfs2/stack_user.c
> +++ b/fs/ocfs2/stack_user.c
> @@ -635,7 +635,7 @@ static const struct file_operations ocfs2_control_fops = {
> .owner = THIS_MODULE,
> };
>
> -struct miscdevice ocfs2_control_device = {
> +static struct miscdevice ocfs2_control_device = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = "ocfs2_control",
> .fops = &ocfs2_control_fops,
>

--

Life's Little Instruction Book #356

"Be there when people need you."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/