Re: [PATCH v2] sched: push rt tasks only if newly activatedtaskshave been added

[Gregory Haskins]

>>> On Mon, Apr 21, 2008 at 12:25 PM, in message
<Pine.LNX.4.58.0804211224380.18530@xxxxxxxxxxxxxxxxxxx>, Steven Rostedt
<rostedt@xxxxxxxxxxx> wrote: 


> 
> I'm betting that this needs a CONFIG_SMP around it.

Indeed, thanks!  Will send update against sched-devel with this fix.


> 
> -- Steve
> 
>>  	inc_cpu_load(rq, p->se.load.weight);
>>  }
>>
>> @@ -913,7 +920,7 @@ static int push_rt_task(struct rq *rq)
>>  	int ret = 0;
>>  	int paranoid = RT_MAX_TRIES;
>>
>> -	if (!rq->rt.overloaded)
>> +	if (!rq->rt.overloaded || rq->rt.pushed)
>>  		return 0;
>>
>>  	next_task = pick_next_highest_task_rt(rq, -1);
>> @@ -973,6 +980,15 @@ out:
>>  }
>>
>>  /*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/