Re: [PATCH] Removing dead code in /drivers/net/wan/hdlc_fr.c

[Jeff Garzik]

Krzysztof Halasa wrote:
> From: Cédric Augonnet <Cedric.Augonnet@xxxxxxxxxxx>
>
> Removing dead code in /drivers/net/wan/hdlc_fr.c
>     
> The local variable "prefix" is never used anymore, and the content of
> this string appears a bit later, directly in a call to "alloc_netdev"
> after doing exactly the same if/else test. So there seems to be no
> point keeping those 4 lines anymore.
>     
> Signed-off-by: Cédric Augonnet <cedric.augonnet@xxxxxxxxxxxx>
> Signed-off-by: Krzysztof Hałasa <khc@xxxxxxxxx>
>
> diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c
> index c4ab032..520bb0b 100644
> --- a/drivers/net/wan/hdlc_fr.c
> +++ b/drivers/net/wan/hdlc_fr.c
> @@ -1090,10 +1090,6 @@ static int fr_add_pvc(struct net_device *frad, unsigned int dlci, int type)
>  	pvc_device *pvc = NULL;
>  	struct net_device *dev;
>  	int result, used;
> -	char * prefix = "pvc%d";
> -
> -	if (type == ARPHRD_ETHER)
> -		prefix = "pvceth%d";
>  
>  	if ((pvc = add_pvc(frad, dlci)) == NULL) {

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/