Re: [PATCH 2/11] x86: convert to generic helpers for IPI functioncalls

From: Jeremy Fitzhardinge
Date: Sat Apr 26 2008 - 05:00:19 EST


Ingo Molnar wrote:
* Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:

This converts x86 and x86-64 to use the new helpers for smp_call_function() and friends, and adds support for smp_call_function_single().

nice stuff. The x86 and generic bits:

Acked-by: Ingo Molnar <mingo@xxxxxxx>

this has been brewing for months, what is the testing/confidence status of it? Could we still merge it into v2.6.26? (i think we should)

I commented on an earlier version of this patch, but it looks like it will break Xen. If you enable CONFIG_XEN, it will try to define both native and Xen versions of arch_send_call_function[_single]_ipi(). It needs to vector them via smp_ops.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/