On Mon, Apr 28, 2008 at 02:23:26PM +0300, Adrian Hunter wrote:But these don't make much sense to me. Why would you want to be ableWell, its just more convenient for us. If I know the bug is somewhere in
to compile out printks at this granularity? Why not enable all of them
when CONFIG_UBIFS_FS_DEBUG is enabled?
the journal, I enable the journal messages - less flooding. We may
lessen the amount, but it is still handy to have some classes of
prints separate.
We will think how to lessen the amount and granularity of this.
note that this last line was _not_ quoted in my mail.
Christoph Hellwig wrote:It's everything but convenient :) Please make it one config option toSurely that judgement should be made by people who actually debug UBIFS.
compile in all debug code and then have a module option to select the
verbosity level at runtime.
You have gone off on a tangent. The original context was discussing the
need for granulated debug messages. I have restored the context above.
I think you haven't read my statement at all. Please look at the quoted
bit above. There is nothing against having different
vebosity/granularity levels, quite to the contrary. I just told you
that a run-time selection of them is everything but convenient and they
should rather be at runtime.
You seem to have mistakenly inferred I was impugning your judgement. That
was not the point.
No, the point was that you didn't read my message and/or assumes just
because I'm not 100% on your line of reasoning I'm against you.
Coming back to your issue of a mount-time option for debug messages. I am
not sure any other file systems do that. In general I would say having to
switch on the debug config option and also change either the kernel command
line or init scripts, seems in fact much less convenient.
It means you can be debug different bits without recompiling which is a
very good thing. Especially if you're debugging moves from one area to
another.