Re: [patch 0/2] Immediate Values - jump patching update
From: H. Peter Anvin
Date: Mon Apr 28 2008 - 17:04:27 EST
Ingo Molnar wrote:
* H. Peter Anvin <hpa@xxxxxxxxx> wrote:
Mathieu Desnoyers wrote:
Thanks to Peter for the review.
Just in case someone gets the wrong idea...
I still think this is the completely wrong approach.
hm, can it result in a broken kernel? If yes, how? Or are your
objections more higher level?
My objections are higher level, I believe the current code is (a)
painfully complex, and I'd rather not see it in the kernel, and (b) the
wrong thing anyway.
Put a 5-byte nop in as the marker, and patch it with a call instruction,
out of line, to a collector function.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/