Re: patch sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch added to gregkh-2.6 tree

From: SL Baur
Date: Tue Apr 29 2008 - 03:48:21 EST


On 4/28/08, gregkh@xxxxxxx <gregkh@xxxxxxx> wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor
>
> to my gregkh-2.6 tree. Its filename is
>
> sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch

> + char devt_str[15];
> +
> + if (kobj) {
> + format_dev_t(devt_str, dev->devt);

This part is ugly, but is not the fault of the patch. The ill-
considered interface for `format_dev_t' is something that probably
noone wants to fix.

Otherwise, still OK with me.

Reviewed-by: SL Baur <steve@xxxxxxxxxx>

(Is Reviewed-by not sticky?)

-sb
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/