Re: [patch] PCI: export resource_wc in pci sysfs

From: Andrew Morton
Date: Tue Apr 29 2008 - 18:24:57 EST


On Wed, 30 Apr 2008 00:03:46 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> +static int pci_create_attr(struct pci_dev *pdev, int num, int write_combine)
> +{
> + /* allocate attribute structure, piggyback attribute name */
> + int name_len = write_combine ? 13 : 10;
> + struct bin_attribute *res_attr;
> + int retval;
> +
> + res_attr = kzalloc(sizeof(*res_attr) + name_len, GFP_ATOMIC);
> + if (res_attr) {
> + char *res_attr_name = (char *)(res_attr + 1);
> +
> + if (write_combine) {
> + pdev->res_attr_wc[num] = res_attr;
> + sprintf(res_attr_name, "resource%d_wc", num);
> + res_attr->mmap = pci_mmap_resource_wc;
> + } else {
> + pdev->res_attr[num] = res_attr;
> + sprintf(res_attr_name, "resource%d", num);
> + res_attr->mmap = pci_mmap_resource_uc;
> + }
> + res_attr->attr.name = res_attr_name;
> + res_attr->attr.mode = S_IRUSR | S_IWUSR;
> + res_attr->size = pci_resource_len(pdev, num);
> + res_attr->private = &pdev->resource[num];
> + retval = sysfs_create_bin_file(&pdev->dev.kobj, res_attr);
> + } else
> + retval = -ENOMEM;
> +
> + return retval;
> +}

That GFP_ATOMIC should be switched to GFP_KERNEL.

Do we reeeeeeeely need to pull this
tack-the-string-onto-the-end-of-the-struct stunt? If we didn't do that,
this code could then be taught about kasprintf() and things like that "?
13 : 10" could be thankfully laid to rest.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/