Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix

From: Ingo Molnar
Date: Wed Apr 30 2008 - 17:20:56 EST



* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

> I thought the many years old rule for Linux kernel is to fix the
> issues properly and not turn kernel into patchwork of crappy code.

correct, except if that would mean breakage for users.

> If we want to fix the randconfi issue I'd rather revert commit
> 66242f7ec531953fbc2f4040c5ffe1f1ffe6c5c9 for now (they only thing it
> did was beautify menuconfig look) and wait for Kconfig to be fixed. It
> is not driver's task to track through all dependencies.

yep ... just dont export our internal crappiness to testers and users.

i'm not suggesting this is your fault in any way - but nevertheless many
other subsystems have to deal with the same Kconfig issues and they
manage to limp along.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/