Re: [PATCH 0/3] Add API for weak DMA masks

From: Alan Cox
Date: Thu May 01 2008 - 12:37:53 EST


> Why do we need it? Is the call to set the 32bit mask when it fails
> a too big burden for the driver author?

We have tons of drivers that go

try and set 64bit
oh failed
try and set 32 bit
oh worked

When what most actually want is "set it no more than this wide" - a
request or even a "pci_set_best_mask()" type idea.

Lots less code duplication.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/