Re: PNP: set IRQ index in sysfs "set irq" interface

From: Rene Herman
Date: Sun May 04 2008 - 09:47:26 EST


On 01-05-08 23:39, Bjorn Helgaas wrote:

We have to set the ISAPNP register index when setting an IRQ via
the sysfs interface. We already do it for IO, MEM, and DMA
resources; I just missed the IRQ one.

This needs to be in 2.6.26.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>

Index: work10/drivers/pnp/interface.c
===================================================================
--- work10.orig/drivers/pnp/interface.c 2008-05-01 15:26:28.000000000 -0600
+++ work10/drivers/pnp/interface.c 2008-05-01 15:26:39.000000000 -0600
@@ -424,7 +424,7 @@
start = simple_strtoul(buf, &buf, 0);
pnp_res = pnp_add_irq_resource(dev, start, 0);
if (pnp_res)
- nirq++;
+ pnp_res->index = nirq++;
continue;
}
if (!strnicmp(buf, "dma", 3)) {

Ha, my ack wasn't on that one...

But what I wanted to ask -- judging from my .gitconfig (as opposed to my memory) I haven't done anything special to get the -p (--show-c-function) functionality from git-diff. Do you do anything special to not get it? It really helps when looking at patches.

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/