Re: [PATCH REPOST] CPA: Add statistics about state of direct mappingv4

[Thomas Gleixner]

On Fri, 2 May 2008, Andi Kleen wrote:
> 
> Signed-off-by: Andi Kleen <ak@xxxxxxx>
> Signed-off-by: Andi Kleen <andi@xxxxxxxxxxxxxx>

Interesting SOB chain :)

> +static unsigned long direct_pages_count[PG_LEVEL_NUM];
> +
> +void __meminit update_page_count(int level, unsigned long pages)

Why __meminit ? This is used in split_large_page()

> +{
> +#ifdef CONFIG_PROC_FS

Why keep an empty function when PROC_FS is disabled ?

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/