Re: [patch 01/10] vfs: add path_create() and path_mknod()

From: Andrew Morton
Date: Tue May 06 2008 - 00:13:35 EST


On Mon, 05 May 2008 12:16:22 +0200 Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> R/O bind mounts require operations which modify the filesystem to be
> wrapped in mnt_want_write()/mnt_drop_write(). Create helpers which do
> this, so callers won't need to bother, and more importantly, cannot
> forget! Call these path_*, analogous to vfs_*. Since there are no
> callers of vfs_* left, make them static.

ooh, yum. This appears to address my main complaint about the r-o-bind-mount
stuff: fragility.

> Overall this patchset is just 23 lines in the red, but at the same
> time it fixes several places in nfsd and the whole of ecryptfs, where
> the mnt_want_write/drop_write() calls were missing.

Yeah, like that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/