Re: [patch 06/15] sysfs: dont call notify_change

[Miklos Szeredi]

> > sysfs_chmod_file() calls notify_change() to change the permission bits
> > on a sysfs file.  Replace with explicit call to sysfs_setattr() and
> > fsnotify_change().
> > 
> > This is equivalent, except that security_inode_setattr() is not
> > called.  This function is called by drivers, so the security checks do
> > not make any sense.
> 
> Are you sure?  As a user, you can chmod the sysfs file and it will
> stick,

Right, but that's not sysfs_chmod_file() but sys_chmod(), which calls
notify_change(), which calls security_inode_setattr().

sysfs_chmod_file() is just called by a couple of drivers to change the
file mode during operation, it's never called by user action directly.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/