Re: Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad

From: Jeremy Fitzhardinge
Date: Tue May 06 2008 - 11:32:54 EST


Linus Torvalds wrote:
You should have used a pagetable-specific macro, becuse PAGE_MASK is simply fundamentally WRONG, and has absolutely nothing to do with the PFN bits, whether sign-extended or not!

The fact is, the page frane number bits are *not* ~PAGE_MASK or anything like that. They share only the low bits - not the high bits.

Yes. There's already a PTE_MASK for masking out the PFN vs the flags in a pte, but it isn't used consistently (perhaps at all).

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/