Re: [PATCH] fix apple alu keyboard with numpad

From: Matthew Garrett
Date: Thu May 08 2008 - 13:44:33 EST


On Thu, May 08, 2008 at 07:29:14PM +0200, Dag Bakke wrote:
> Matthew Garrett wrote, On 05/07/2008 01:43 AM:
> >On Tue, May 06, 2008 at 12:54:06PM -0700, Andrew Morton wrote:
> >
> >>>-static int hid_apple_fnmode = 1;
> >>>+static int hid_apple_fnmode = 2;
> >
> >Regardless of anything else, we don't want this hunk.
> >
>
> Was my reasoning for this change off ("F-keys used more often that
> multimediakeys, ergo make that the default"), or is your resistance to
> this change due to some kind of policy?

It's a change in behaviour of a wide range of keyboards, and it's in a
patch that is supposed to be fixing a single keyboard. Personally, I
suspect that the people who are going to want the F-keys by default are
the people who are easily able to change this behaviour and the ones who
aren't are the ones who are going to expect their keyboard to behave
like it did under MacOS. But that's a separate argument for a separate
patch :)

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/