Re: [PATCH] x86: Remove 6 bank limitation in 64 bit MCE reporting code

[Venki Pallipadi]

On Thu, May 08, 2008 at 02:27:58PM -0700, H. Peter Anvin wrote:
> Venki Pallipadi wrote:
> >Eliminate the 6 bank restriction in 64 bit mce reporting code. This 
> >restriction
> >is artificial (due to static creation of sysfs files) and 32 bit code
> >does not have any such restriction.
> >
> >This change helps in reporting the details of machine checks on a machine 
> >check
> >exception with errors in bank 6 and above on CPUs that support those banks.
> >Without the patch, machine check errors in those banks are not reported.
> >
> >We still have 128 (MCE_EXTENDED_BANK) bank restriction instead of max 256
> >supported in hardware. That is not changed in the patch below as it will 
> >have
> >some user level mcelog utility dependency, with bank 128 being used for
> >thermal reporting currently.
> >
> >The patch below does not create sysfs control (bankNctl) for banks higher
> >than 6 as well. That needs some pre-cleanup in /sysfs mce layout, removal 
> >of
> >per cpu /sysfs entries for bankctl as they are really global system level
> >control today. That change will follow. This basic change is critical to
> >report the detailed errors on banks higher than 6.
> >
> >Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>
> 
> Any chance you could add unifying the 32 and 64-bit code to your list, 
> since you're already working on eliminating differences there?
> 

It was tried earlier
http://www.ussg.iu.edu/hypermail/linux/kernel/0505.2/0982.html
but never made it.

Yes. Will add that to the todo list.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/