Re: [Patch 1/9] fs/exec.c: export free_arg_pages

[WANG Cong]

On Sat, May 10, 2008 at 08:12:51PM +0100, Al Viro wrote:
>On Thu, May 08, 2008 at 09:52:26PM +0800, WANG Cong wrote:
>> free_arg_pages() is used to clean the pages allocated by copy_strings_kenrel().
>> Since copy_strings_kernel() is exported, so should be free_arg_pages().
>
>Not really.  free_arg_pages() cleans them all at once; copy_strings_kernel()
>adds to pile.  free_arg_pages() is called once for _all_ of them.  And that
>happens in fs/exec.c, so it doesn't need to be exported.

Yes, thanks.
I already saw your patch, looks better than mine. ;-)

-- 
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/