Re: [RFC/PATCH] printk: detect incomplete lines

[Pekka Enberg]

On Mon, May 12, 2008 at 2:49 PM, Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:
>  This printk() problem has been bugging me for a long time. Consider the
>  following code:
>
>  diff --git a/init/main.c b/init/main.c
>  index ddada7a..777e02d 100644
>  --- a/init/main.c
>  +++ b/init/main.c
>  @@ -452,17 +452,38 @@ static void __init setup_command_line(char *command_line)
>   * gcc-3.4 accidentally inlines this function, so use noinline.
>   */
>
>  +static void printk_thread(const char *msg, unsigned long wait)
>  +{
>  +       int i = 0;
>  +
>  +       while(true) {
>  +               if (i == 0)
>  +                       printk(KERN_INFO "Here we go: ");
>  +
>  +               printk("%s%s", msg, i < 7 ? ", " : "\n");

You are supposed to use KERN_CONT here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/