Re: [PATCH] drivers/scsi/qla1280.c; was Re: Buffered I/O to blockdevice very slow and other SCSI issues...

From: Jes Sorensen
Date: Tue May 13 2008 - 03:16:16 EST


Andrew Morton wrote:
--- a/drivers/scsi/qla1280.c 2008-05-03 11:59:44.000000000 -0700
+++ b/drivers/scsi/qla1280.c 2008-05-10 21:32:23.451341969 -0700
@@ -2007,7 +2007,7 @@ qla1280_set_defaults(struct scsi_qla_hos
nv->bus[bus].config_2.req_ack_active_negation = 1;
nv->bus[bus].config_2.data_line_active_negation = 1;
nv->bus[bus].selection_timeout = 250;
- nv->bus[bus].max_queue_depth = 256;
+ nv->bus[bus].max_queue_depth = 32;
if (IS_ISP1040(ha)) {
nv->bus[bus].bus_reset_delay = 3;
@@ -2051,7 +2051,7 @@ qla1280_config_target(struct scsi_qla_ho
status = qla1280_mailbox_command(ha, 0x0f, mb);
/* Save Tag queuing enable flag. */
- flag = (BIT_0 << target) & mb[0];
+ flag = (BIT_0 << target);
if (nv->bus[bus].target[target].parameter.tag_queuing)
ha->bus_settings[bus].qtag_enables |= flag;

Thanks. I tagged this for a -stable backport (assuming that is
appropriate?)


Sounds good, given the nature of this it should go into stable as well
as current.

Acked-by: Jes Sorensen <jes@xxxxxxx>

Cheers,
Jes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/