Re: [PATCH 2/3] x86: janitor work in bugs.c

[Ingo Molnar]

* Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> wrote:

> -		printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> +		printk(KERN_EMERG "No coprocessor found and no math "
> +			"emulation present.\n");

generally we do not break up strings mid-stream - that makes grepping 
harder. _At most_ we do something like:

		printk(KERN_EMERG
		       "No coprocessor found and no math emulation present.\n");

> -/* trap_init() enabled FXSR and company _before_ testing for FP problems here. */
> +/* trap_init() enabled FXSR and company _before_ testing for FP problems
> + * here. */

that's not the proper multi-line comment style, this would be:

  /*
   * trap_init() enabled FXSR and company _before_ testing for
   * FP problems here.
   */

same for other places in this patch and for your next patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/