Re: [RFC/PATCH 4/6] memcg: shmem reclaim helper

[KAMEZAWA Hiroyuki]

On Wed, 14 May 2008 16:15:49 +0800
Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> > +	while(!progress && --retry) {
> > +		progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> > +	}
> 
> This is wrong. How about:
> 	do {
> 		...
> 	} while (!progress && --retry);
> 
Ouch, or retry--....

Thank you for catching.

Thanks
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/