Re: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC

From: Alessandro Zummo
Date: Wed May 14 2008 - 14:53:21 EST


On Wed, 14 May 2008 17:23:35 +0300
"Kim B. Heino" <Kim.Heino@xxxxxxxxxxxx> wrote:

>
>
> >> +struct m41t94 {
> >> + struct rtc_device *rtc;
> >> + u8 buf[8]; /* Burst read cmd + 7 registers */
> >> +};
> > why are you keeping the buffer here?
>
> rtc-max6902.c did that too... Fixed.

d'oh! I missed it. :)

> > the choice is up to you, but I'd use the century bit if there
> > is one.
>
> Ok, I'll add support for century bit. Again there are some other
> rtc-drivers (like rtc-m41t80.c and rtc-ds1307.c) not using it.

it's not mandatory, just a suggestion.

>
> I'll wait for more comments and post a new patch tomorrow.

ok, thanks.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/