Re: [PATCH 2/3] sysfs: remove error messages for -EEXIST case

From: David Miller
Date: Thu May 15 2008 - 01:34:48 EST


From: Stephen Hemminger <shemminger@xxxxxxxxxx>
Date: Wed, 14 May 2008 18:16:03 -0700

> It is possible that the entry in sysfs already exists, one case of this is
> when a network device is renamed to bonding_masters. Anyway, in this case
> the proper error path is for device_rename to return an error code, not to
> generate bogus backtrace and errors.
>
> Also, to avoid possible races, the create link should be done before the
> remove link. This makes a device rename atomic operation like other renames.
>
> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/