Re: [PATCH] x86/xen: fix arbitrary_virt_to_machine()

[Jeremy Fitzhardinge]

Jan Beulich wrote:
> While I realize that the function isn't currently being used, I still
> think an obvious mistake like this should be corrected.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -60,7 +60,7 @@ xmaddr_t arbitrary_virt_to_machine(unsig
>  {
>  	unsigned int level;
>  	pte_t *pte = lookup_address(address, &level);
> -	unsigned offset = address & PAGE_MASK;
> +	unsigned offset = address & (PAGE_SIZE - 1);
>   

Yeah.  But I'd prefer "~PAGE_MASK".

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/