Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies()???

[Arjan van de Ven]

On Thu, 15 May 2008 23:26:22 +0200
"Christophe Jaillet" <christophe.jaillet@xxxxxxxxxx> wrote:

> From: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
> 
> Hi, here is a patch against linux/drivers/net/r6040.c.
> 
> Compared to other places in the kernel, I think that this driver
> misuses the function round_jiffies.
> 
> 
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
> 
> Signed-off-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
> 
> ---
> 
> --- linux 2.6.25/drivers/net/r6040.c	2008-05-15
> 23:21:28.000000000 +0200 +++ linux
> 2.6.25/drivers/net/r6040.c.cj	2008-05-15 22:16:44.000000000
> +0200 @@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da }
>  
>  	/* Timer active again */
> -	mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
> +	mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
>  }
>  

good catch!
Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/