Re: [PATCH] crypto: make michael_block a function

From: Johannes Berg
Date: Fri May 16 2008 - 04:11:22 EST

On Fri, 2008-05-16 at 09:01 +0200, Sebastian Siewior wrote:
> * Harvey Harrison | 2008-05-15 23:17:17 [-0700]:
> >Make the michael_block macro a function and change the calling
> >function to take a struct michael_mic_ctx * and the value for
> >the initial xor with ctx->l.
> >
> >Also open-code xswap in its one use in michael_block.
> Does this change have any performance impact?
> The only user is wireless (I guess). Is it used frequently (sign every
> packet for instance) or once in a while (in every re-keying)?

Every packet. I have no idea whether it has performance impact, very
hard to even guess.


Attachment: signature.asc
Description: This is a digitally signed message part