Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F

[Greg KH]

On Fri, May 16, 2008 at 05:13:45PM +0900, Atsushi Nemoto wrote:
> # Sorry, resend with new linux-usb ML address.
> 
> On Fri, 18 Jan 2008 18:58:28 +0900, Akira Tsukamoto <akirat@xxxxxxxxxxxxxxxxxx> wrote:
> > pl2303: add support for RATOC REX-USB60F
> > 
> > This patch adds support for RATOC REX-USB60F Serial Adapters,
> > which is widely used in Japan recently.
> > 
> > Signed-off-by: Akira Tsukamoto <akirat@xxxxxxxxxxxxxxxxxx>
> > ---
> > 
> > diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c linux-2.6.24-rc8/drivers/usb/serial/pl2303.c
> > --- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c	2008-01-18 18:11:51.000000000 +0900
> > +++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.c	2008-01-18 18:43:28.000000000 +0900
> > @@ -65,6 +65,7 @@ static struct usb_device_id id_table [] 
> >  	{ USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) },
> >  	{ USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) },
> >  	{ USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) },
> > + 	{ USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) },
> >  	{ USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) },
> >  	{ USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) },
> >  	{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
> 
> Hi.  I tried RATOC REX-USB60F with pl2303 driver and got oops in
> pl2303_open().  The pl2303 expects a interrupt_in endpoint but my
> device does not have interrupt_in.  So this line in pl2303_open()
> cause oops.
> 
> 	port->interrupt_in_urb->dev = serial->dev;
> 
> This device works fine with the ftdi_sio driver, with "vendor=0x584
> product=0xb020" module option.  (0x584 is RATOC_VENDOR_ID and 0xb020
> is RATOC_PRODUCT_ID_USB60F).

Ick, thanks for letting me know.

> Is the pl2303 driver appropriate for this device?

Based on your lsusb output, no, I think it is the ftdi_sio one.  I'll go
apply your patch.

thanks again,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/