Re: [PATCH] virtio_net: free transmit skbs in a timer

[Rusty Russell]

On Sunday 18 May 2008 16:40:05 Avi Kivity wrote:
> Rusty Russell wrote:
> > On Friday 16 May 2008 01:32:47 Avi Kivity wrote:
> >> Mark McLoughlin wrote:
> >>> I think Rusty is speaking from the POV of the guest driver - i.e. that
> >>> virtio_net should never disable notifications on the xmit queue using
> >>> disable_cb()?
> >>>
> >>> Sounds like you think agree, but that the host side should throttle the
> >>> rate of xmit notifications?
> >>
> >> Yes.
> >
> > But performance is going to suck in the meantime, as currently our host
> > doesn't do this.
>
> That's what the feature bits are for.

OK.  And since the current situation is that the host doesn't throttle, the 
feature bit should be "don't throttle, host is doing it for you", and Mark's 
patch should go in...

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/