Re: [PATCH, RFC] Char dev BKL pushdown v2
From: Roland Dreier
Date: Mon May 19 2008 - 00:01:26 EST
Great work, Jon! It's really cool to see some real momentum towards
getting rid of the BKL at last.
> drivers/infiniband/core/ucm.c | 2 +
> drivers/infiniband/core/user_mad.c | 7 ++++
> drivers/infiniband/core/uverbs_main.c | 9 ++++--
> drivers/infiniband/hw/ipath/ipath_file_ops.c | 2 +
All of these changes look fine from a pure "push the BKL down" point of
view. However I am 99% sure no BKL use is required in any of these (and
I will think deeper to get another .9% surer tomorrow).
Is the plan that we have a pure "push the BKL down" changeset merged,
and then I can merge BKL removal patches for these places that never
needed the BKL? (I guess I can send you such a patch to base on top of
your tree for when Linus pulls it? Is 2.6.27 the plan?) The
alternative is to never add the BKL to these places as part of this
patch -- which seems to be a bad, risky plan, since if any mistakes are
made, then bisection just lands on some giant patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/