Re: [PATCH] utimensat() non-conformances and fixes -- version 2
From: Michael Kerrisk
Date: Mon May 19 2008 - 08:24:50 EST
On Mon, May 19, 2008 at 11:50 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>> Regarding your suggestions above, are you meaning something like the
>> patch below?
>> The patch is a little less pretty than I'd like because of the need to
>> return EACCES or EPERM depending on whether (times == NULL). In
>> particular, these lines in utimes.c:
>> + if (!times && error == -EPERM)
>> + error = -EACCES;
>> seem a little fragile (but maybe I worry too much).
> It's not only fragile, it's ugly as sin. I'd rather do it this way:
> - initialize error to zero
> - if no write access then set error, and the ATTR_TIMES_UPDATE(*) flag
> - set error2 from result of notify_change()
> - if error is zero then return error2, otherwise return error
> (*) I've been mulling over the name and perhaps ATTR_OWNER_CHECK would
> be better, or something that implies that it's not really about
> updating the times, but about checking the owner.
This all makes sense, but...
> Also could you do the patch against the
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git vfs-cleanups
> tree, which does big structural cleanups to do_utimes?
You keep moving the goalposts here... First, it was provide an
obvious correct fix (for the non-conformances); then: can you cleanup
the owner checks; then: can you rewrite against my git tree... My
time at the moment is fairly limited, and I have a problem: currently,
I'm not a git user. That'll change soon, but I don't have the time to
change it now. Can I just download a snapshot tarball of your git
changes somehwere? Alternatively, when do you expect your changes to
make it into an rc?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/