Re: [PATCH] [1/11] Remove BKL from remote_llseek
From: Christoph Hellwig
Date: Mon May 19 2008 - 10:03:11 EST
On Mon, May 19, 2008 at 02:31:10PM +0200, Andi Kleen wrote:
> - Replace remote_llseek with remote_llseek_unlocked (to force compilation
> failures in all users)
> - Change all users to either use remote_llseek directly or take the
> BKL around. I changed the file systems who don't use the BKL
> for anything (CIFS, GFS) to call it directly. NCPFS and SMBFS and NFS
> take the BKL, but explicitely in their own source now.
> I moved them all over in a single patch to avoid unbisectable sections.
Good idea, but it could be done a little bit nicer still.
Your new remote_llseek_unlocked is the same as generic_file_llseek
except for the fact that it doesn't take i_mutex. So I'd rather
call it generic_file_llseek_nolock and make generic_file_llseek call
it. While you're at it you could also add some kerneldoc documents
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/