Re: aperture_64: use symbolic constants
From: Dave Jones
Date: Tue May 20 2008 - 12:40:44 EST
On Tue, May 20, 2008 at 05:32:15PM +0200, Pavel Machek wrote:
> > Instead of making this an inline, we could add it to the agpgart code
> > and export it, and have the gart-iommu code call it.
> > You can't build the IOMMU code without agpgart anyway, and having this inlined
> > in both places seems a bit wasteful.
> > Additionally, it would mean not having a function in a header file,
> > which always strikes me as a wrong thing to do.
> Can you elaborate? Yes, it would be nicer if this went to .c
> somewhere, but aperture_64.c seems unsuitable (we need it on 32-bit,
> too, right?)... plus it was __init in one place, and __devinit in the
> other, so I figured out "inline it so that it works automagically".
> Plus, I don't think it should go into drivers/agp, as iommu code in
> arch/x86/kernel seems to be able to work without that...?
If you enable IOMMU, you _have_ to enable AGP. (well, you don't have to,
it does a 'select AGP' for you when you enable it :-)
It does this because the agpgart driver needs to know how much of the
aperture has been stolen for IOMMU use, and I think it already uses some
functions from that driver already.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/