Re: [PATCH 1/3][-mm] add class_reclassify macro
From: Matthew Wilcox
Date: Tue May 20 2008 - 13:36:52 EST
On Tue, May 20, 2008 at 10:30:45AM -0700, Andrew Morton wrote:
> Well what are these lockdep warnings? Normally such a warning means that
> we have a locking bug. I _assume_ that you've determined that the warnings
> are false-positives?
Andrew, we already discussed this on the thread you started that you
then ignored ...
> The warning which Mariusz Kozlowski discovered ("Subject: Re:
> 2.6.26-rc2-mm1: possible circular locking dependency detected") was
> triggered by the "class semaphore to mutex" conversion and it looks
> like a real bug to me. Would your patch prevent warnings such as that
> one from being available to us?
The problem is that you add one type of class which then adds devices
that are of another class. This is not a bug. My proposal is to give
each sysfs class its own lock class; Dave's is to only do it for the
two classes he knows about that do this.
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/