Re: [PATCH 05/21] drivers/usb: use aligned-endian get/put helpers

From: Harvey Harrison
Date: Tue May 20 2008 - 14:46:29 EST


On Tue, 2008-05-20 at 11:06 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---

After all that I compiled with the wrong config to make sure
it all compiled after splitting, extra bracket in devio.c

> drivers/usb/c67x00/c67x00-hcd.c | 4 ++--
> drivers/usb/core/devio.c | 12 ++++++------
> drivers/usb/gadget/net2280.c | 2 +-
> drivers/usb/host/ehci.h | 6 ++----
> drivers/usb/host/isp116x-hcd.c | 4 ++--
> drivers/usb/host/ohci.h | 16 ++++++----------
> drivers/usb/host/uhci-hub.c | 6 +++---
> drivers/usb/misc/auerswald.c | 2 +-
> drivers/usb/serial/garmin_gps.c | 9 ++++-----
> drivers/usb/storage/isd200.c | 4 ++--
> 10 files changed, 29 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index de17738..b44a061 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -993,18 +993,18 @@ static int proc_do_submiturb(struct dev_state *ps, struct usbdevfs_urb *uurb,
> kfree(dr);
> return -EFAULT;
> }
> - if (uurb->buffer_length < (le16_to_cpup(&dr->wLength) + 8)) {
> + if (uurb->buffer_length < get_le16(&dr->wLength) + 8)) {
^
Sorry.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/