[PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed

From: Robert Olsson
Date: Tue May 20 2008 - 15:05:08 EST



Denis V. Lunev writes:

> The problem is that pktgen_thread_worker can not be executed if kthread_stop
> has been called too early. Insert a completion on the normal initialization
> path to make sure that pktgen_thread_worker will gain the control for sure.


Yes how about if we move the wait_for_completion() to pg_cleanup before
we remove the threads. And move the complete() last in pktgen_thread_worker.
This completion would sync with both start and stop.

Cheers.
--ro


> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 8dca211..fdf5377 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -390,6 +390,7 @@ struct pktgen_thread {
> int cpu;
>
> wait_queue_head_t queue;
> + struct completion start_done;
> };
>
> #define REMOVE 1
> @@ -3414,6 +3415,7 @@ static int pktgen_thread_worker(void *arg)
> BUG_ON(smp_processor_id() != cpu);
>
> init_waitqueue_head(&t->queue);
> + complete(&t->start_done);
>
> pr_debug("pktgen: starting pktgen/%d: pid=%d\n", cpu, task_pid_nr(current));
>
> @@ -3615,6 +3617,7 @@ static int __init pktgen_create_thread(int cpu)
> INIT_LIST_HEAD(&t->if_list);
>
> list_add_tail(&t->th_list, &pktgen_threads);
> + init_completion(&t->start_done);
>
> p = kthread_create(pktgen_thread_worker, t, "kpktgend_%d", cpu);
> if (IS_ERR(p)) {
> @@ -3639,6 +3642,7 @@ static int __init pktgen_create_thread(int cpu)
> }
>
> wake_up_process(p);
> + wait_for_completion(&t->start_done);
>
> return 0;
> }
> --
> 1.5.3.rc5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/