Re: [patch 10/21] buffer heads: Support slab defrag

From: David Chinner
Date: Tue May 20 2008 - 17:46:55 EST

On Tue, May 20, 2008 at 10:56:23AM +0400, Evgeniy Polyakov wrote:
> On Tue, May 20, 2008 at 10:25:03AM +1000, David Chinner (dgc@xxxxxxx) wrote:
> > + filemap_fdatawrite_range(mapping, start, end);
> >
> > Where [start,end] span page->index and are is large enough
> > to get a substantial sized I/O to disk (say at least SWAP_CLUSTER_MAX
> > pages, preferrably larger for 4k page size machines).
> Or just sync_inode().

Oh, god no. Let's not put the inode_lock right at the top of
the VM page cleaning path. We don't need to modify inode state,
the superblock dirty lists, etc - all we need to do is write
dirty pages on a given mapping in a more efficient manner.


Dave Chinner
Principal Engineer
SGI Australian Software Group
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at