Re: [PATCH] or51132.c: unaligned
From: Al Viro
Date: Tue May 20 2008 - 20:57:19 EST
On Tue, May 20, 2008 at 05:51:28PM -0700, Harvey Harrison wrote:
> > ... and the point of that would be? FWIW, I really don't like the ...p()
> > forms - they are hard to distinguish from normal ones visually and any
> > possible performance benefit is too small for most of the uses. IOW,
> > it's mostly redundant API.
> I sent a patchset getting rid of the p variants earlier today, Dave
> Miller made a good point that some arches have well optimized versions
> of these as they have specific machine instructions they can use.
Thus the "mostly" part - on hot paths the microoptimization is worth the
trouble. None of the places in question is on such paths...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/