Re: [RFC][PATCH 0/3] configfs: Make nested defaultgroups lockdep-friendly
From: Peter Zijlstra
Date: Wed May 21 2008 - 07:00:04 EST
On Wed, 2008-05-21 at 12:25 +0200, Louis Rilling wrote:
> > http://programming.kicks-ass.net/kernel-patches/concurrent-pagecache/23-rc1-rt/radix-concurrent-lockdep.patch
> Thanks for pointing this out.
> Yes this could solve part of the issue, at the price of duplicating the
> inode mutex class. However, this still does not solve the issue when
> deleting config_groups, since in that case all nodes of the tree are
> locked. Thinking about adding lockdep support for concurrent locking of
> the direct children of a node in a tree...
Why doesn't sysfs have this problem? - the code says configfs was
derived from sysfs.
Also, do you really need to hold all locks when removing something?
sound like a bit overdone. Also realise there is a maximum number of
held locks - various people have already requested it to be increased or
made dynamic. We're reluctant in doing so because we feel lock chains
should not be of unlimited length. The deeper the chains the bigger the
PI overhead etc..
As to modifying lockdep - it currently doesn't know about trees and
teaching it about them isn't easy.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/