Re: [-mm][PATCH 3/4] cgroup mm owner callback changes to add taskinfo (v5)
From: Balbir Singh
Date: Thu May 22 2008 - 06:15:54 EST
Andrew Morton wrote:
> On Wed, 21 May 2008 20:59:59 +0530 Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
>> This patch adds an additional field to the mm_owner callbacks. This field
>> is required to get to the mm that changed. Hold mmap_sem in write mode
>> before calling the mm_owner_changed callback
>> + * The callbacks are invoked with mmap_sem held in read mode.
> Is that true?
>> + down_write(&mm->mmap_sem);
>> cgroup_mm_owner_callbacks(mm->owner, c);
> Looks like write-mode to me?
Yes, obsolete comment. Will fix.
Linux Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/