[PATCH] block: reorder cfq_queue to save space on 64bit builds

From: Richard Kennedy
Date: Thu May 22 2008 - 11:03:11 EST


saves 8 bytes of padding & increases objects/slab from 30 to 32 on my
AMD64 config


Signed-off-by: Richard Kennedy <richard@xxxxxxxxxxxxxxx>

---

patch against 2.6.26-rc2
running successfully on my AMD64 desktop

Richard


diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index b399c62..4df3f05 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -124,6 +124,8 @@ struct cfq_data {
struct cfq_queue {
/* reference count */
atomic_t ref;
+ /* various state flags, see below */
+ unsigned int flags;
/* parent cfq_data */
struct cfq_data *cfqd;
/* service_tree member */
@@ -138,14 +140,14 @@ struct cfq_queue {
int queued[2];
/* currently allocated requests */
int allocated[2];
- /* pending metadata requests */
- int meta_pending;
/* fifo list of requests in sort_list */
struct list_head fifo;

unsigned long slice_end;
long slice_resid;

+ /* pending metadata requests */
+ int meta_pending;
/* number of requests that are on the dispatch list or inside driver */
int dispatched;

@@ -153,8 +155,6 @@ struct cfq_queue {
unsigned short ioprio, org_ioprio;
unsigned short ioprio_class, org_ioprio_class;

- /* various state flags, see below */
- unsigned int flags;
};

enum cfqq_state_flags {



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/