Re: [PATCH] wm97xx-core: Report a phys for WM97xx touchscreens
From: Mark Brown
Date: Thu May 22 2008 - 11:08:21 EST
On Thu, May 22, 2008 at 09:41:48AM -0400, Dmitry Torokhov wrote:
> On Thu, May 22, 2008 at 12:35:06PM +0100, Mark Brown wrote:
> > phys is displayed in various diagnostic output so ensure that it is set
> > to something sensible.
> Phys is used to describe the physical connection of a device that is
> ideally not changing between reboots so having it set up based on
> device's bus_id is not a best option I think.
It didn't seem terribly wonderful to me either but I saw that some other
drivers were doing the same thing so I assumed it was idiomatic. A
quick survey of devices on my laptop suggets that it's getting filled in
with USB bus IDs for some devices.
For a WM97xx device it should actually be OK almost all the time - AC97
bus identifiers are fixed in hardware, there would only be a problem if
additional AC97 buses are added which is relatively unlikely, especially
in the embedded applications where the WM97xx devices get used.
However, if it's supposed to be OK to leave this null then that would be
> What tools besides evbug use phys? They probably should display both
> phys and sysfs paths (I will be changing evbug soon).
It was actually evbug that prompted this - it prints a rather alarming
'Connected device: "foo", NULL' when phys is left empty.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/