Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()
From: Christoph Lameter
Date: Thu May 22 2008 - 12:52:36 EST
On Thu, 22 May 2008, Pekka Enberg wrote:
> Hi Matt,
> On Thu, May 22, 2008 at 6:01 PM, Matt Mackall <mpm@xxxxxxxxxxx> wrote:
> > As I've said several times, ksize() on kmem_cache_alloced objects
> > -cannot work- on SLOB. Calling ksize() on something returned by
> > kmem_cache_alloc is a categorical error.
> Well, it's a historical fact that ksize() worked for both kmalloc()
> and kmem_cache_alloc() (see the kernedoc comment in mm/slab.c).
> However, I think we should just look at getting rid of ksize()
> altogether as it's only (ab)used by the nommu code and few call-sites
> that open-code krealloc().
Good idea. if krealloc is an allocator internal function then it can
establish the size as needed and we do not have ksize available.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/