Re: [patch 05/14] hpfs: dont call permission()

From: Christoph Hellwig
Date: Fri May 23 2008 - 05:20:19 EST

On Wed, May 21, 2008 at 07:15:03PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> hpfs_unlink() calls permission() prior to truncating the file. HPFS
> doesn't define a .permission method, so replace with explicit call to
> generic_permission().
> This is equivalent, except that devcgroup_inode_permission() and
> security_inode_permission() are not called.
> The truncation is just an implementation detail of the unlink, so
> these security checks are unnecessary.
> I suspect that even calling generic_permission() is unnecessary, since
> we shouldn't mind if the file isn't writable. But I leave that to the
> maintainer to decide.

Okay to me but rather pointless. And I agree to the last stance that
the whole logic in hpfs_unlink really needs sorting out by someone who
understands that filesystem.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at