Re: [PATCH] snapshot: Push BKL down into ioctl handlers

From: Rafael J. Wysocki
Date: Fri May 23 2008 - 07:22:21 EST

On Friday, 23 of May 2008, Alan Cox wrote:
> > >
> > > + lock_kernel();
> > > +
> >
> > Hm, well, I admit I'm a bit ignorant as far as the chardev locking is
> > concerned, but can you please tell me why would that be wrong if we didn't call
> > lock_kernel() here at all?
> I've just been pushing the lock down. If the code already has enough
> internal locking for things like multiple ioctls in parallel then you can
> probably kill it entirely - but that needs someone who knows that driver
> well to decide and evaluate.

Thanks, I'll have a look.

ACK for the patch from me.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at