Re: [PATCH] video4linux: Push down the BKL

From: Jonathan Corbet
Date: Fri May 23 2008 - 12:09:36 EST


Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> The problem is that currently they are almost all unsafe - I did a quick
> survey as part of the changes. Pushing it down to the video2_ioctl is a
> starting point, but the v4l layer is going to need a lot of love and its
> own gradual migration.

Agreed.

> Right now we've gone from BKL buried in fs to BKL at top of v4l layer
> which is indeed only a starting point. I'd assumed the same as you are
> think a new video_ioctl2 and switching drivers one by one (I was assuming
> adding video2_ioctl_unlocked())

It sound like we're thinking the same way, yes. Except I'd pick the
long name for the one we want to get rid of :)

BTW, drop me a pointer if you'd like this series pulled into the
ever-growing bkl-removal tree.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/