Re: [PATCH 1/3] page-flags: record page flag overlays explicitly

From: KOSAKI Motohiro
Date: Mon May 26 2008 - 00:39:35 EST


Hi

Thank you nice patch.

> Some page flags are used for more than one purpose, for example
> PG_owner_priv_1. Currently there are individual accessors for each user,
> each built using the common flag name far away from the bit definitions.
> This makes it hard to see all possible uses of these bits.
>
> Now that we have a single enum to generate the bit orders it makes sense
> to express overlays in the same place. So create per use aliases for
> this bit in the main page-flags enum and use those in the accessors.
>
> Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxx>

My review found no bug.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/